[jira] [Commented] (OFBIZ-5098) javascript error in hidden form

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532409#comment-13532409 ]

Naofumi Fukue commented on OFBIZ-5098:
--------------------------------------

Hi Jacques,

For example, edit applications/accounting/webapp/accounting/WEB-INF/controller.xml like this.

    <request-map uri="invoice.pdf">
        <security https="true" auth="true"/>
        <event name="test" type="java" path="org.ofbiz.webapp.event.TestEvent" invoke="test"/> <= add this
        <response name="success" type="view" value="InvoicePDF"/>
    </request-map>

And in invoice screen, click 'PDF' button.

Exist or not exist above line, generated html is different.
 
               

> javascript error in hidden form
> -------------------------------
>
>                 Key: OFBIZ-5098
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5098
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Naofumi Fukue
>            Priority: Minor
>         Attachments: HtmlMenuRenderer.java.patch
>
>
> HtmlMenuRenderer generates like bellow form tags. It generates double target="_BLANK" , then cause javascript error.
>   <li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a target="_BLANK" href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>
>  
> document.InvoiceSubTabBar_pdf_LF_8 is undefined @ javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()
> Index: framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
> ===================================================================
> --- framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java (revision 1419381)
> +++ framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java (working copy)
> @@ -455,10 +455,12 @@
>                  writer.append(name);
>                  writer.append("\"");
>              }
> -            if (UtilValidate.isNotEmpty(targetWindow)) {
> -                writer.append(" target=\"");
> -                writer.append(targetWindow);
> -                writer.append("\"");
> +            if (!"hidden-form".equals(linkType)) {
> +                if (UtilValidate.isNotEmpty(targetWindow)) {
> +                    writer.append(" target=\"");
> +                    writer.append(targetWindow);
> +                    writer.append("\"");
> +                }
>              }
>  
>              writer.append(" href=\"");

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira