[jira] [Commented] (OFBIZ-5164) Patch: Refactor Ofbiz*Transform to reduce deduplication

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612704#comment-13612704 ]

Adrian Crum commented on OFBIZ-5164:
------------------------------------

From your single-method Java class:

import freemarker.template.TemplateModelException;
import freemarker.template.TemplateScalarModel;

Clearly, this code is FreeMarker-related and it should go in the FreeMarker utility class.

Creating a new class whose only purpose is to hold a single static method is silly.

               

> Patch: Refactor Ofbiz*Transform to reduce deduplication
> -------------------------------------------------------
>
>                 Key: OFBIZ-5164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Christoph Neuroth
>            Priority: Trivial
>         Attachments: OFBIZ-5164.patch
>
>
> Leaving the campground a bit cleaner than I found it, please find attached a patch which removes some duplication from the *Transform classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira