[
https://issues.apache.org/jira/browse/OFBIZ-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634171#comment-13634171 ]
Carsten Schinzer commented on OFBIZ-5179:
-----------------------------------------
The scope of this creeps unfortunately. It turns out that PayPal services are apparently not ootb usable, the following seem to be missing before they will work:
- checkExternalPayment returns the wrong value when PayPal contiditions are met
- although PayPaylServices.java is there and respective java servicedef is also in place, the mapping of context parameters for service execution is entirely missing, ie
-- Simple Method Map Processings are missing
-- Simple Method Events are missing
-- Simple Method Services are missing
- IN map parameters also need to be reviewed as the interface methods only partially define the required parameters that are used and accessed in PayPalServices.java
- some review might be required for consistent parameter use on PayPalServices.java as well (I already found eg. the Locale being accessed through the cart and directly on context)
On top of that, the de translations on the payPalEvents are also missing. (I got the full pacakge here :D) that will be tracked on a separate JIRA though, since it is only mutually related to this one.
I have reviewed the estimated effort and upped it to 4 hrs.
> checkExternalPayment returns payflowpro instead of paypal
> ---------------------------------------------------------
>
> Key: OFBIZ-5179
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5179> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: independant
> Reporter: Carsten Schinzer
> Fix For: SVN trunk
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The following method contains a false return value:
> org.ofbiz.order.schoppingcart.CheckOutEvents#checkExternalPayment
> It verifies a Paypal payment method is defined for the ProductStore, but then returns a value 'payflowpro' in return which is clearly false as PayFlowPro is a separate external payment method.
> The patch/fix will allow to check for both, PayPal and PayFlowPro as external payment methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
