[
https://issues.apache.org/jira/browse/OFBIZ-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701923#comment-13701923 ]
Hans Bakker commented on OFBIZ-5257:
------------------------------------
isSeervicequestion output = boolean
checkFunction output can be anything
so everything fine here.
> Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong
> -----------------------------------------------------------------------
>
> Key: OFBIZ-5257
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5257> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Pierre Smits
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5257-ACCTG-WrongMethodNaming.patch
>
>
> The name of this method in accounting services doesn't tell what it does.
> You have to go into the description what the functionality of the method is, namely checking whether an invoice is a foreign currency.
> Best practice is to have the name of the function reflect the functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
