[jira] [Commented] (OFBIZ-5279) Wrong to use !jQuery('#content-messages') in \framework\images\webapp\images\selectall.js line #354

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5279) Wrong to use !jQuery('#content-messages') in \framework\images\webapp\images\selectall.js line #354

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718056#comment-13718056 ]

Jacques Le Roux commented on OFBIZ-5279:
----------------------------------------

Wei Zhang,

I did not test, about your 1st comment
{quote}
In addition the hideErrorContainer function in line #349 cannot hide the error message. Maybe we should use jQuery('#content-messages').html('');
{quote}
is it still true after the typo fix?
               

> Wrong to use !jQuery('#content-messages') in \framework\images\webapp\images\selectall.js line #354
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5279
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5279
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wei Zhang
>
> I think we should use
> if(jQuery('#content-messages').length==0)
> insead of
> if(!jQuery('#content-messages'))
> in framework\images\webapp\images\selectall.js line #354.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira