[jira] [Commented] (OFBIZ-5294) Common screen decorators don't follow best practice of being in CommonScreens.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5294) Common screen decorators don't follow best practice of being in CommonScreens.xml

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254838#comment-14254838 ]

Adrian Crum commented on OFBIZ-5294:
------------------------------------

Mridul picked out a good example - AgreementScreens.xml.

Notice this line in the FindAgreement screen:

{code}
<decorator-screen name="CommonAgreementDecorator" location="${parameters.agreementDecoratorLocation}">
{code}

If agreementDecoratorLocation does not exist, then the screen widget will look in the current file for "CommonAgreementDecorator". If I want to reuse the FindAgreement screen in my own component, I can leave agreementDecoratorLocation undefined and use the existing CommonAgreementDecorator, or I can define agreementDecoratorLocation (in web.xml) to point to a file containing my own version of CommonAgreementDecorator.

So, this approach is flexible and it makes screen widget reuse easier.


> Common screen decorators don't follow best practice of being in CommonScreens.xml
> ---------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5294
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5294
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk
>            Reporter: Pierre Smits
>
> Commonly screen decorators are found in file CommonScreens.xml of the component. However, this is not the case for various screens in the Product component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)