[jira] [Commented] (OFBIZ-5312) Proposal: URL-Generation Changes

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802668#comment-13802668 ]

Parimal Gain commented on OFBIZ-5312:
-------------------------------------

Hi Jacquaes/Paul/Jinghai,

Here is the result of initial testing:
1. After applying the patch I have submitted I'm able to build and run the application.
2. After some modification in CatalogUrlSeoTransform.java I'm able to create the User friendly url.
3. Modification done in makeCategoryUrl() and makeProductUrl() and the modification is :
Removed: urlBuilder.append(((HttpServletRequest) request.getSession().getServletContext()).getContextPath());
Added : urlBuilder.append(request.getSession().getServletContext().getContextPath());
4. Following Url is created:
Category Url : http://localhost:8080/ecommerce/category/small-gizmos-101.html
Product Url : http://localhost:8080/ecommerce/product/round-gizmo-gz-2644.html
5. When clicked on any category or product with above pattern its return 404 Not Found error and in console following error occurred:
[ControlServlet.java:140:INFO ] [[[product(Domain:http://localhost)] Request Begun, encoding=[UTF-8]- total:since last(Begin):0.0]]
[CmsEvents.java:145:INFO ] Path INFO for Alias: product/round-gizmo-gz-2644.html
[CmsEvents.java:391:WARN ] Could not verify contentId [product] to webSiteId [WebStore], returning code 404

Looking at the issue I found that these request are handling through ControlServlet.java instead of SeoCatalogUrlServlet.java because web.xml has defined the as

<servlet-mapping>
        <servlet-name>SeoCatalogUrlServlet</servlet-name>
        <url-pattern>/products/*</url-pattern>
 </servlet-mapping>

So my question is what configuration needs to do to handle these requests or how category and product request will be handled?????

> Proposal: URL-Generation Changes
> --------------------------------
>
>                 Key: OFBIZ-5312
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5312
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: changes, ecommerce, friendly, seo, url
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, SeoContextFilter.java.patch
>
>
> [This was proposed by Paul Piper in Nabble 7 months ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html]. Here is quoted Paul's proposal
> {quote}
> Hey Everyone,
> over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz changes that we believe the entire community could benefit from. The changes have been implemented in parts in Syracus (www.syracus.net) for a while now, but we figured that some of which are too crucial for ofbiz' success in the long run, so we are considering the contribution (as we did with the SOLR component).
> As you are probably aware, OFBiz has a pretty uncommon way of generating URLs. Most of this has to do with the fact that OFBiz uses a servlet (ControlServlet)  to handle all requests. The servlet is mounted at /control, so that it won't interfere with other servlets. Though functionally valid, this has the sideeffect that all urls are actually created on /control, which is neither pretty, nor good by any measures of SEO. It also means that a few 302 redirects are necessary to forward the user from / to /control/main. It also makes requests more complicated, since many forwards are necessary whenever somebody wants to move away from this implementation.
> Since this is hurtful to many of the implementers, I wanted to discuss whether or not you guys would be interested in the changes we have made. The functional changes contain:
> * Removal of /control out of all the urls
> * SEO-friendly URLS
> * Configurable product/category and other URLs
> * Frontpage mapping from /main to /
> It was tested on our end and contains all necessary improvements (Transforms, Sample Configuration, Servlets & Filters) for it to be applicable.
> If interested, I would create a new JIRA ticket for this and after a few minor internal discussions, we will gladly provide the rest of you with it.
> Regards,
> Paul
> {quote}
> There is even a patch, mostly done by Jinghai Shi, that I attach here. Even if it has been already used in [Syracus|http://syracus.net/] since early this year, some help would be needed to test it thoroughly in OFBiz.
> Then we should discuss if it's the way to go. I believe it is. Who needs a /control/ or /main by default in ecommerce urls? Would you not prefer http://localhost:8080/ecommerce/ over http://localhost:8080/ecommerce/control/main ?

--
This message was sent by Atlassian JIRA
(v6.1#6144)