[jira] [Commented] (OFBIZ-5314) Shipment cancellation doesn't revert inventory accounting quantity total

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794036#comment-13794036 ]

Jacopo Cappellato commented on OFBIZ-5314:
------------------------------------------

Unfortunately the fix is not in the right direction, Jacques please revert it and reopen the ticket.
accountingQuantityTotal is used to implement LIFO/FIFO inventory valuation methods: according with these methods, the inventory items issued/reverted may be different from the ones used to D/C the inventory (and COGS); this is the reason we are maintaining different fields for qoh and accounting quantity.
The issue we have to address is that in the service "createAcctgTransForCanceledSalesShipmentIssuance" the LIFO/FIFO methods are not implemented.
Please look at:
createAcctgTransForSalesShipmentIssuance
to see how LIFO/FIFO is implemented when the issuance is done: we have to revert that transaction.
I am also attaching a patch (that should not be committed as is, because it is incomplete) to provide some ideas to properly fix the issue: unfortunately I do not have time to complete its implementation now.

> Shipment cancellation doesn't revert inventory accounting quantity total
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-5314
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5314
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 11.04
>            Reporter: Christian Carlow
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: IssuanceServices.xml.patch, suggested-fix.patch
>
>
> Canceling a shipment doesn't update the corresponding inventory_item accounting_quantity_total.
> http://ofbiz.135035.n4.nabble.com/Shipment-cancellation-doesn-t-revert-inventory-accounting-quantity-total-td4643866.html

--
This message was sent by Atlassian JIRA
(v6.1#6144)