[jira] [Commented] (OFBIZ-5315) view-entity complex-alias field name bug when view-entities reference other view-entities

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5315) view-entity complex-alias field name bug when view-entities reference other view-entities

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766402#comment-13766402 ]

Jacques Le Roux commented on OFBIZ-5315:
----------------------------------------

If I refer to the other usage of SqlJdbcUtil.filterColName() for the alias column name in ModelViewEntity.java

colValue = alias.entityAlias + "." + SqlJdbcUtil.filterColName(aliasedField.getColName());
colName = SqlJdbcUtil.filterColName(colValue);

It seems your patch should be rather

String colName = entityAlias + "_" + SqlJdbcUtil.filterColName(modelField.getColName());

Did you test it?

               

> view-entity complex-alias field name bug when view-entities reference other view-entities
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5315
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5315
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04
>            Reporter: Christian Carlow
>            Priority: Minor
>             Fix For: Release Branch 11.04
>
>         Attachments: ModelViewEntity.java.patch
>
>
> Field names used in complex-alias are named incorrectly when SQL statements are generated.  
> The following complex alias:
> <alias name="quantity">
>   <complex-alias operator="-">
>     <complex-alias-field entity-alias="A" field="field1"/>
>     <complex-alias-field entity-alias="B" field="field2"/>
>   </complex-alias>
> </alias>
> Will result with the following generated SQL when A and B are also view-entities:
> SELECT (C.A.field1 + C.B.field2)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira