[jira] [Commented] (OFBIZ-5330) trivial error correction to fieldlookup.js

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778776#comment-13778776 ]

Pierre Smits commented on OFBIZ-5330:
-------------------------------------

Having a colour hardcoded in this patch shouldn't be the way, as in:

src.css("background-color", "yellow");

Developers of custom applications applying this functionality will have a hard time resolving this when they want to have another background.
               

> trivial error correction to fieldlookup.js
> ------------------------------------------
>
>                 Key: OFBIZ-5330
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5330
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5330.patch
>
>
> correct following trivial issues:
> 1. in lookupDescriptionLoaded.prototype.update, not assign the form when try to get filed object by its name
> 2. in setSourceColor, variable "target" should be given parameter "src"
> please see attached patch file for details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira