[
https://issues.apache.org/jira/browse/OFBIZ-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814567#comment-13814567 ]
Leon commented on OFBIZ-5384:
-----------------------------
Jacques,
Sorry not notice your very recent commits.
I have no idea about the "invitation" even did not know ofbiz has such feature before you mentioned here.
But as I know, the current "order entry" handles shipping address correctly for both group and person customer. I test to create some orders after removing that block of codes, everything was OK.
Btw, I don't think the code of r1178353 was tested completely. Since the signature of method ShoppingCart.setShippingContactMechId was already "public void (int, String)" 3 years ago (see
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?view=markup&pathrev=1030158). Means the code of r1178353 did not work from very beginning.
Anyway, your commits has already fix the issue. As I know, even if you set the shipping info when order init, it will be overridden in shipping setting step of order entry. So it's safe to keep the code there in case somewhere used.
> Not need to set shipping info in CheckInits.groovy
> --------------------------------------------------
>
> Key: OFBIZ-5384
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5384> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5384.patch
>
>
> In the tail of CheckInits.groovy, there're some code to set shipping info of assigned party into shopping cart. But it's not necessary, and the code is buggy (1. check Person only 2. no shoppingCart.setShippingContactMechId(String) method defined).
> So I remove these codes from CheckInits.groovy. Pls see attached patch.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Locked
