[jira] [Commented] (OFBIZ-5397) Incorrect selected ship destination displayed on purchase order entry form

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5397) Incorrect selected ship destination displayed on purchase order entry form

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829197#comment-13829197 ]

Jacques Le Roux commented on OFBIZ-5397:
----------------------------------------

Your solution works well with radio buttons. There are a lof of information to show in each ship group address and I believe in such case it's easier to read as it's currently done (multiple lines for eadh address) than using a drop-down.

I suggest to take the KISS way and to commit your patch as is.


> Incorrect selected ship destination displayed on purchase order entry form
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-5397
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5397
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Christian Carlow
>         Attachments: OFBIZ-5397.patch
>
>
> Selected ship group destinations are displayed incorrectly on the purchase order entry Shipping page.  The first ship group destination is selected without checking if any of the other destinations were selected.  Part of the problem is that the facilityId of the destination chosen is not specified in the parameters passed to CheckOutEvents finalizeOrderEntry function.
> To reproduce:
> 1.  Create an order to DemoSupplier
> 2.  Add any supplier product to the order and click Finalize Order
> 3.  Click Continue until you reach the Shipping page
> 4.  Choose the second shipping destination and click Continue
> 5.  Click the Shipping link to go back to the previous shipping page
> 6.  Notice that the second destination is not selected
> The second destination is actually assigned because it appears on the confirmation page but no code exists to check the correct radio option.  The facilityId will have to be passed in somehow to allow such logic to be correctly implemented.



--
This message was sent by Atlassian JIRA
(v6.1#6144)