[jira] [Commented] (OFBIZ-5422) htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5422) htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845539#comment-13845539 ]

Gareth Carter commented on OFBIZ-5422:
--------------------------------------

Sorry Jacques, to repoduce this I went into find party screen, search for all and manually set the view size (I had to click next and change the VIEW_SIZE parameter in the url).

In my description I mention 24/2=12 and 24/5=4.8,
24 is number of parties I had
2/5 is the view size

It doesnt matter what the item size is (aslong as its more than 0), you just have to make sure listSize divides by viewSize evenly. In my case 24/2 divided evenly and which should have have given 12 pages but gave 13.

> htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5422
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5422
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Gareth Carter
>            Priority: Minor
>         Attachments: htmlFormMacroLibrary.patch
>
>
> There are 2 issues with the existing code.
> 1 - floor is applied to viewSize only not the computed value
> 2 - if the listSize divides with viewSize evenly, you'll get one extra
> eg
> 24/2=12 - no of pages = 13
> 24/5=4.8 - no of pages = 5



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)