[
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036244#comment-17036244 ]
Pierre Smits commented on OFBIZ-5426:
-------------------------------------
Hi [~pawan],
Is this patch also somewhere implemented in a development/feature branch in a publicly available git repo (e.g. on Github)?
If so, it may be beneficial to fellow community members to use that for review (and other collaboration) purposes. And if everything checks out, the project can/may decide to use a pull request to establish an officially endorsed 'OFBiz feature branch' to make it available to the entire community, or directly merge it into another branch (trunk and or release branch).
IMO, providing enhancement contributions (bug fixes, improvements and new features) through development branches in public git repos is more favourable as it leverages key feature(s) of git.
It avoids you to upload additional enhancements to the solution to this tickets, but also to have reviewing community members to download these enhancements and apply them to their review branch.
See also:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=145724011> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-5426
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5426> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Trunk
> Reporter: Leon
> Assignee: Deepak Dixit
> Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch
>
>
> Due to revision 1529838, the length of data type "email" was increased from 254 to 320. But It makes the ofbiz failed to create tables such as "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
