[jira] [Commented] (OFBIZ-5453) Set field in (at least) widget screen does not take into account a locale for (at least) the Float type

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5453) Set field in (at least) widget screen does not take into account a locale for (at least) the Float type

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865809#comment-13865809 ]

Jacques Le Roux commented on OFBIZ-5453:
----------------------------------------

We currently have any coordinate systems, and it works. All we need is to know which maps renderer system to use.

We defined few of them, the possibilities are:
{code}
    <DataSourceType dataSourceTypeId="GEOPOINT_SUPPLIER" description="Name of GeoPoints publisher"/>
    <DataSource dataSourceId="GEOPT_GOOGLE" dataSourceTypeId="GEOPOINT_SUPPLIER" description="Google as GeoPoint supplier"/>
    <DataSource dataSourceId="GEOPT_YAHOO" dataSourceTypeId="GEOPOINT_SUPPLIER" description="Yahoo as GeoPoint supplier"/>
    <DataSource dataSourceId="GEOPT_MICROSOFT" dataSourceTypeId="GEOPOINT_SUPPLIER" description="Microsoft as GeoPoint supplier"/>
    <DataSource dataSourceId="GEOPT_MAPTP" dataSourceTypeId="GEOPOINT_SUPPLIER" description="MapTP a GeoPoint supplier"/>
{code}

This has been a bit abused by Erwan when he implemented the map rendering by address done by Google. He used a GEOPT_ADDRESS_GOOGLE which is not defined as a dataSourceTypeId="GEOPOINT_SUPPLIER". He aslo forgot to add GEOPT_OSM in this list when he implemened the Openlayers rendering examples.

That's why I finally don't see a need for multiple coordinate systems. But I'm maybe missing something? What would they be used for in OFBiz?

> Set field in (at least) widget screen does not take into account a locale for (at least) the Float type
> -------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5453
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 12.04, Release Branch 13.07
>
>         Attachments: OFBIZ-5453.patch
>
>
> While working on Google Maps API migration from V2 to V3 I discovered an issue which is reflected by those 2 commits
> * http://svn.apache.org/viewvc?view=revision&revision=892579 
> * http://svn.apache.org/viewvc?view=revision&revision=895950
> In other words if you pass something like
> <set field="geoPoints[+0].lat" value="37.4419" type="Float"/>
> in a French OS or browser context you will get 37.0 in OFBiz context
> But if you pass
> <set field="geoPoints[+0].lat" value="37,4419" type="Float"/>
> in an English OS or browser context you will get 37.0 in OFBiz context
> So we need either to fix this in code (ModelWidgetAction.java[132,171]) or to add a way to pass a locale to force/fix the Float(others?) value in OFBiz context (this is needed for instance for geolocation)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)