[jira] Commented: (OFBIZ-552) Integration Shark 1.1_2 into OfBiz

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465431 ]

Jacques Le Roux commented on OFBIZ-552:
---------------------------------------

Serguey, John,

I was considering to apply this new patch. My 1st review shows me that they are 1550 tabs (minus those generated by differ tool) in this patch. Please Serguey consider reading the reference I gave to you above, thanks. This is not a problem for this patch, I will take care of that. But please in future think about it. Commiter could be a hard job sometimes...

Here are some other comments

Not sure lines 491-862 are relevant ?

There are still some copyright notices, notably in
    ThreadedToolAgentManager.java
    SharkContainer.java
but that's not a big problem. I can take care of that (btw they are not Serguey's)

There are 4 "//System.err.println" but this is perhaps needed for future debugging ? In this case it seems better to use std OFBiz feature (Debug.logInfo, etc.)

There are 155 "System.out.println", this should be replaced by Debug.logInfo or .Verbose, or else as needed

There are 45 "Debug.log(". Note that this will *always* prompt in log and perhaps should be replaced by Debug.logInfo or .Verbose, or else as needed
 
ASL header is missing in new file SharkConstants.java. Beware that the header has changed : http://www.apache.org/legal/src-headers.html

A part from this minor problems the patch looks good.

They are 92 files changed in this 7200 lines patch so now that John seems interested to test it I will wait his comments before doing more work on this.

BTW there is a bug in Jira (I will post about it in Apache infra) that prevents to get rid of the old patch.

> Integration Shark 1.1_2 into OfBiz
> ----------------------------------
>
>                 Key: OFBIZ-552
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-552
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Sergey Shutov
>         Attachments: shark.diff, shark_2.diff
>
>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira