[
https://issues.apache.org/jira/browse/OFBIZ-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325636#comment-14325636 ]
Pierre Smits commented on OFBIZ-5532:
-------------------------------------
I have concerns with this issue and the associated patch.
First of all, time entry registrations cater to a specific need. Namely, to register how much time is spend on a specific activity (task). Extending the entity to register values for quantityProduced and quantityRejected is not required for registering time spent. For registering those values we have other entities.
Furthermore, adding a field for registering setup time is superfluous. Setup activities are like any other task in manufacturing. They should have their own task assignment and subsequent time registration. That both setup and execution are registered on a fixed asset assignment isn't the same as a task execution by persons.
> Improve production run task declarations to create time entries for each declaration
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-5532
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5532> Project: OFBiz
> Issue Type: Improvement
> Components: manufacturing
> Affects Versions: Trunk
> Reporter: Christian Carlow
> Assignee: Pierre Smits
> Attachments: OFBIZ-5532.patch
>
>
> Timesheet entries are supposed to be created when produced and rejected quantities are declared for production run tasks. ProductionRunServices.updateProductionRunTask accepts the partyId as a parameter but code that is supposed to use it to create timesheet entries has been commented out. Rev 910230 shows that the commented code has always existed. There are also FIXME comments to add quantityProduced, quantityRejected, and setupTime fields to the timesheet entity.
> This functionality is vital for determining which employees are responsible for rejects.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
