[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894857#comment-13894857 ]

Adrian Crum commented on OFBIZ-5534:
------------------------------------

In addition to the problem you describe, we also have a potential problem with rollbacks. Consider a transaction with multiple updates - let's say we issue a commit after each update, then put the updated value in the cache. Then later in the same transaction, an update attempt triggers a rollback. The previously updated values are left in the cache - they are not removed.


> Dirty reads from entity cache
> -----------------------------
>
>                 Key: OFBIZ-5534
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5534
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk, Release Branch 12.04, Release Branch 13.07
>            Reporter: Jacopo Cappellato
>         Attachments: unittest-dirtyreadsfromcache.patch
>
>
> Even if database transaction isolation level is set to "ReadCommitted", a transaction can get uncommitted records from the entity cache, under certain circumstances.
> Here is a test case:
> 1) transaction T1 creates a record
> 2) T1 calls findOne to retrieve it: the read will be successful (because T1 can read data generated in T1 even if not committed) and the record will be added to the cache
> 3) T1 calls another service with requireNewTransaction set to true: this will run the second service in a new transaction T2
> 4) T2 calls findOne to retrieve the record created by T1: if useCache is set to false it should fail; if useCache is set to true it will succeed (getting the record from cache, even if the data is not committed to the db)
> The result in #4 is wrong because T2 should not see the uncommitted record
> We should never add uncommitted records to the entity cache.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)