[
https://issues.apache.org/jira/browse/OFBIZ-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906753#comment-13906753 ]
Praveen Agrawal commented on OFBIZ-5544:
----------------------------------------
Hi Jacques,
Thanks for looking into this.
No, i didn't got any error, this is just a safety check that if amount is null then don't create an OrderAdjustment entry.
What is your opinion about adding the 'DINSTINGUISHING_FEAT' to the feature Map in the getFeatureIdQtyMap function.
> The getFeatureIdQtyMap function doesn't include the DISTINGUISHING_FEAT into the featureMap
> -------------------------------------------------------------------------------------------
>
> Key: OFBIZ-5544
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5544> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Praveen Agrawal
> Attachments: OFBiz-5544.patch
>
>
> The getFeatureIdQtyMap function in ShoppingCartItem.java doesn't include the DISTINGUISHING_FEAT in featureMap so if we want to calculate the Shipping amount based on Distinguishing feature, this method doesn't return the Distinguishing Feature in Feature Map.
> If we add DISTINGUISHING_FEAT as productFeatureApplTypeId in filterExprs then the feature map would contain the Distinguishing feature in addition to Standard and Required Feature.
> Also in ShoppingCartItem.java, putAdditionalProductFeatureAndAppl method, i think the OrderAdjustment should only be included when the amount is not null.
> The above issues are exists in all other branches including Trunk
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
Locked
