[
https://issues.apache.org/jira/browse/OFBIZ-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041567#comment-14041567 ]
Adam Heath commented on OFBIZ-5565:
-----------------------------------
Ok, yes, I see how this broke. My salted crypt feature *did* break this. However, the code itself is doing things quite wrong.
It was encrypting the value *itself*, then passing it in as a map thru findByAnd. Due to the entity conditions *not* encrypting their field values, this worked before my key-encrypting-key change.
Now that the conditions properly support encrypted field value lookups, the code in this function becomes radically simpler. Just pass the incoming code directly into the entity engine.
> FinAccountHelper.getFinAccountFromCode() no longer returns financial account
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-5565
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5565> Project: OFBiz
> Issue Type: Bug
> Components: accounting, order
> Affects Versions: SVN trunk, Release Branch 13.07
> Environment: Primarily tested on Ubuntu, but affects all OS.
> Reporter: Vyom Jain
> Assignee: Adam Heath
> Fix For: SVN trunk, Release Branch 13.07
>
> Attachments: OFBIZ-5565.patch
>
>
> FinAccountHelper.getFinAccountFromCode() in trunk as well as in some of the released versions is no longer able to fetch the Financial Account ID.
> So all features dependent on this method would no longer work (an example being paying by gift card during order entry process).
> Per my research, this stopped working method post some changes related to how data is encrypted (two strings will not have similar encrypted string).
> I had tried this on a fresh SVN trunk checkout with absolutely no changes (had been using Derby database).
> Furthermore, the ant target gen-kek references old jars and that needs fixing as well.
> Steps to test -
> 1. Create a new Financial account (gift certificate) for DemoCustomer -
https://demo-trunk.ofbiz.apache.org/accounting/control/FindFinAccount?ownerPartyId=DemoCustomer and deposit some funds into it.
> 2. Create an order for DemoCustomer from the Order Manager application.
> 3. Use "Quick Finalize Order", try paying by the gift card created in step #1.
> Observations -
> 1. Returns an error "This gift card does not exist"
> Related User ML post -
http://mail-archives.apache.org/mod_mbox/ofbiz-user/201403.mbox/%3CCAKuEJqZChmJaWF=rZN1z-vUDNZBNSduLJ4j6pxJTD5iJYnUZhg@...%3E> Thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Locked
