[jira] [Commented] (OFBIZ-5591) ofbizCurrency transform does not honor the rounding passed in ofbizCurrency macro.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5591) ofbizCurrency transform does not honor the rounding passed in ofbizCurrency macro.

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944736#comment-13944736 ]

Deepak Dixit commented on OFBIZ-5591:
-------------------------------------

Hi Christian,

Thanks for verifying issue, and provide an alternate patch. If we shifted the if condition one level above then scaleEnabled set to N, as we are reading the scaleEnabled value from general.properties. So please lookinto once again. Also it would be good if we use utility method to check null or empty string value.


> ofbizCurrency transform does not honor the rounding passed in ofbizCurrency macro.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5591
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5591
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 12.04, Release Branch 13.07
>            Reporter: Deepak Dixit
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 12.04, Release Branch 13.07
>
>         Attachments: OFBIZ-5591-alternative-rounding-fix-svn.diff, OFBIZ-5591.patch
>
>
> ofbizCurrency transform does not honor the rounding passed in ofbizCurrency macro. OfbizCurrency transform always used the default rounding set in general.properties file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)