[jira] [Commented] (OFBIZ-5631) service getFxConversion is never used

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5631) service getFxConversion is never used

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001455#comment-14001455 ]

Jacques Le Roux commented on OFBIZ-5631:
----------------------------------------

Hi Pierre,

I see not harm with it, and I guess it's used by Hans in a custom project. So I let him decide (I assign to him), though theoretically yes, things that are not common should not be committed

> service getFxConversion is never used
> -------------------------------------
>
>                 Key: OFBIZ-5631
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5631
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>
> service getFxConversion got incorporated in r891159.
> However, it is not used anywhere.
> I propose to remove it as part of the trim down effort



--
This message was sent by Atlassian JIRA
(v6.2#6252)