[
https://issues.apache.org/jira/browse/OFBIZ-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039995#comment-14039995 ]
chunlinyao commented on OFBIZ-5658:
-----------------------------------
from CATALOG -> Image Management -> Upload view. upload some Images it will call this method. This method is intended to add (count) to the image name, when the file name was already exist. I debugged in it, the imagePath was the absolute path of the image file. So If any parent folder name contains "." , it will not works correctly.
And after review the whole ImageManagementServices.java file. I found it use static variables (ex. imageCount imagePath). It is not thread safe.
> checkExistsImage method in ImageManagementServices
> ---------------------------------------------------
>
> Key: OFBIZ-5658
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5658> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 13.07
> Environment: any
> Reporter: chunlinyao
> Priority: Trivial
>
> I think indexOf(".") in these code should be lastIndexOf(".")
> public static File checkExistsImage(File file) {
> if (!file.exists()) {
> imageCount = 0;
> imagePath = null;
> return file;
> }
> imageCount++;
> String filePath = imagePath.substring(0, imagePath.indexOf("."));
> String type = imagePath.substring(imagePath.indexOf(".") + 1);
> file = new File(filePath + "(" + imageCount + ")." + type);
> return checkExistsImage(file);
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Locked
