[jira] [Commented] (OFBIZ-5658) checkExistsImage method in ImageManagementServices

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040331#comment-14040331 ]

chunlinyao commented on OFBIZ-5658:
-----------------------------------

Hi Jacques,

> Did you not encouters errors (reported in UI for instance)? Are you using a *nix OS (I use Windows hence the question)?
Yes I use OSX not Windows.

> checkExistsImage method in ImageManagementServices
> ---------------------------------------------------
>
>                 Key: OFBIZ-5658
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5658
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 13.07
>         Environment: any
>            Reporter: chunlinyao
>            Priority: Trivial
>
> I think indexOf(".") in these code should be lastIndexOf(".")
> public static File checkExistsImage(File file) {
>         if (!file.exists()) {
>             imageCount = 0;
>             imagePath = null;
>             return file;
>         }
>         imageCount++;
>         String filePath = imagePath.substring(0, imagePath.indexOf("."));
>         String type = imagePath.substring(imagePath.indexOf(".") + 1);
>         file = new File(filePath + "(" + imageCount + ")." + type);
>         return checkExistsImage(file);
>     }

--
This message was sent by Atlassian JIRA
(v6.2#6252)