[jira] Commented: (OFBIZ-576) ProductDisplayWorker.getQuickReorderProducts

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-576) ProductDisplayWorker.getQuickReorderProducts

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485721 ]

Chris Howe commented on OFBIZ-576:
----------------------------------

This turns out to be a referential integrity problem where a productId finds it's way into the reorder list but the product does not exist.  I'm not sure that it can be reproduced in a normal setting.  My only thoughts is that roughly line 184

GenericValue product = orderItem.getRelatedOneCache("Product");

assumes that product can not equal null and then performs a product.get("productId") which will return an NPE.  Since I'm not sure that it can be reproduced without directly and incorrectly purging the product from the database, I'm not sure if this kind of statement needs to be protected.

> ProductDisplayWorker.getQuickReorderProducts
> --------------------------------------------
>
>                 Key: OFBIZ-576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-576
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Chris Howe
>            Priority: Minor
>
> Returns an error in log and doesn't paint the ecommerce screen: minireorderproduct  when a productId doesn't return as expected.  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.