[
https://issues.apache.org/jira/browse/OFBIZ-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138968#comment-14138968 ]
Taher Alkhateeb commented on OFBIZ-5772:
----------------------------------------
Hi Jacques,
Thank you for your usual extended efforts, we definitely appreciate it and benefit from it!
I do speak an RTL language (Arabic) and have a few comments that might help out. For starters, the lang="${langAttr}" modification does not do much on its own for full RTL support except for fixing the exception in freemarker. Beyond that, what really makes RTL work includes:
- The most important thing is CSS fixing not only for right alignment of text, but also menus, trees, and all kinds of html widgets
- setting up the right encoding
- Addition of the RTL unicode marker character where necessary / needed to align right
Arabic language is indeed, quite a challenge. I was considering putting some effort into making some themes other than flatgrey RTL compliant but I remember in the mailing list talks about abandoning some of the themes, and any way testing is difficult wihout first translating all the UI labels.
With respect to your assertion on the sentences being legible in the right direction, it depends if the characters are:
- aligned right (if not, the sentence will break incorrectly on special characters like dots, parenthesis and so on)
- aligned left but the characters are flowing right to left and connecting appropriately
both cases have different workarounds. So again, it all depends on testing. But then again most of the components are not translated in terms of the UI Label Map so we need to first translate those into arabic to ease testing. I translated 90% of ofbiz 12.04 to arabic, but I need to upgrade the addons to be compatible with trunk. I will do my best when I get the chance.
Taher Alkhateeb
> add html/xhtml lang tag
> -----------------------
>
> Key: OFBIZ-5772
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5772> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/ecommerce
> Affects Versions: 12.04.04, 12.04.05
> Reporter: Josip Almasi
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: patch
> Attachments: ecommerce-lang.patch
>
>
> There is no locale string present in any ecommerce pages.
> Thus, crawlers can't determine page language just like that, IOW google will not index web shop just like that, so users can't apply to adsense, etc etc.
> Note that locale (x/html lang) is present in backoffice pages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
