[jira] [Commented] (OFBIZ-5840) Create bootstrap theme

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222427#comment-14222427 ]

Adrian Crum commented on OFBIZ-5840:
------------------------------------

Gavin - I applied the patches, but didn't add the bootstrap theme yet. I want to make sure your patches work with the existing themes. I get an exception when using Tomahawk:

2014-11-23 17:30:33,390 |http-bio-8443-exec-4 |runtime                       |E| Error executing FreeMarker template
freemarker.core._MiscTemplateException: Macro "renderMenuEnd" has no such argument: style

----
FTL stack trace ("~" means nesting-related):
        - Failed at: @renderMenuEnd style="button-bar tab-...  [in template "org.ofbiz.widget.menu.MacroMenuRenderer@125ea95_1040" at line 1, column 1]
----
        at freemarker.core.Environment.visit(Environment.java:646) [freemarker-2.3.21.jar:2.3.21]
        at freemarker.core.UnifiedCall.accept(UnifiedCall.java:80) ~[freemarker-2.3.21.jar:2.3.21]
        at freemarker.core.Environment.visit(Environment.java:257) [freemarker-2.3.21.jar:2.3.21]
        at freemarker.core.Environment.include(Environment.java:1967) [freemarker-2.3.21.jar:2.3.21]
        at org.ofbiz.widget.menu.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:101) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.menu.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:126) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.menu.MacroMenuRenderer.renderMenuClose(MacroMenuRenderer.java:275) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.menu.ModelMenu.renderSimpleMenuString(ModelMenu.java:319) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.menu.ModelMenu.renderMenuString(ModelMenu.java:288) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$Menu.renderWidgetString(ModelScreenWidget.java:1227) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:189) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:203) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:189) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:189) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:189) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:396) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ScreenFactory.renderReferencedScreen(ScreenFactory.java:211) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:589) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:189) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:396) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ScreenFactory.renderReferencedScreen(ScreenFactory.java:211) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:656) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:102) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:189) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ModelScreen.renderScreenString(ModelScreen.java:396) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:134) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.ScreenRenderer.render(ScreenRenderer.java:96) [ofbiz-widget.jar:?]
        at org.ofbiz.widget.screen.MacroScreenViewHandler.render(MacroScreenViewHandler.java:151) [ofbiz-widget.jar:?]
        at org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:988) [ofbiz-webapp.jar:?]
        at org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:674) [ofbiz-webapp.jar:?]
        at org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:210) [ofbiz-webapp.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:620) [servlet-api-3.0.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) [servlet-api-3.0.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:307) [ofbiz-webapp.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:501) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408) [tomcat-7.0.55-catalina.jar:7.0.55]
        at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1070) [tomcat-7.0.55-tomcat-coyote.jar:7.0.55]
        at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:611) [tomcat-7.0.55-tomcat-coyote.jar:7.0.55]
        at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316) [tomcat-7.0.55-tomcat-coyote.jar:7.0.55]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [?:1.7.0_60]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [?:1.7.0_60]
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-7.0.55-tomcat-coyote.jar:7.0.55]
        at java.lang.Thread.run(Thread.java:745) [?:1.7.0_60]

> Create bootstrap theme
> ----------------------
>
>                 Key: OFBIZ-5840
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5840
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework, themes
>    Affects Versions: Trunk
>            Reporter: Julien NICOLAS
>              Labels: bootstrap, theme
>         Attachments: GlobalDecorator.patch, MacroMenuRenderer.patch, OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, bootified.js, bootstrap-theme.zip, bootstrap.zip
>
>
> 1- create a sub-directory called bootstrap under the image webapp to put
> the resources over there (js, css and fonts) as indicated earlier by Gavin.
> (Julien : not sure about location)
> 2- check to make sure that the current version of jQuery is compatible with
> the installed version or upgrade it accordingly
> 3- Create a new theme based on one of the existing themes as suggested by
> Julien and Gavin
> 4- Test the theme by switching to it and handle major bugs / issues.
> 5- Start to make a few test screens utilizing Bootstrap

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)