[jira] [Commented] (OFBIZ-5840) Create bootstrap theme

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5840) Create bootstrap theme

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139753#comment-15139753 ]

Jacques Le Roux commented on OFBIZ-5840:
----------------------------------------

I succeeded to merge the branch in a trunk version back to r1685214. I then svn updated and build all went fine but 2 conflicts I put as resolved (no real merge conflicts). I applied the BranchMergeToTrunk.patch (the one committed in the branch) which is needed because getMenuFromLocation() methods are called in appbar.ftl
I had to fix an issue with
{code}
freemarker.template.TemplateModelException: No error description was specified for this error; low-level message: java.lang.ClassNotFoundException: org.ofbiz.widget.menu.MenuFactory
{code}
where org.ofbiz.widget.menu.MenuFactory should have been  org.ofbiz.widget.model.MenuFactory (I was surprised by that one, Adrian changed it in April 2015). I did it in 3 files: appbar.ftl,  appbarOpen.ftl and header.ftl

Then I got a page at https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y but the menus, nor the lookups (including auto-completion), nor the buttons works. I had a look at the lookupField_patch.patch but it was already applied, so unrelated to the issue. I gave up at this stage... but I did not say my last word yet...

I could commit the current state I have, but I believe it's easy to get to this stage so no need to polute the branches. We will see if we are still interested. It would be a pity to lose the work done, except if someone can give use a good reason?

> Create bootstrap theme
> ----------------------
>
>                 Key: OFBIZ-5840
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5840
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, themes
>    Affects Versions: Bootstrap theme
>            Reporter: Julien NICOLAS
>            Assignee: Jacques Le Roux
>              Labels: bootstrap, theme
>         Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, htmlMenuMacroLibrary.patch, lookupField_patch.patch, pagination_htmlFormMacroLibrary.patch, panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, preferences.png, styling_issue_1.png, styling_issue_2.png, styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, styling_issue_9.png, tab-bar.png, workeffort.PNG
>
>
> 1- create a sub-directory called bootstrap under the image webapp to put
> the resources over there (js, css and fonts) as indicated earlier by Gavin.
> (Julien : not sure about location)
> 2- check to make sure that the current version of jQuery is compatible with
> the installed version or upgrade it accordingly
> 3- Create a new theme based on one of the existing themes as suggested by
> Julien and Gavin
> 4- Test the theme by switching to it and handle major bugs / issues.
> 5- Start to make a few test screens utilizing Bootstrap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)