[jira] [Commented] (OFBIZ-5851) Add ability to assign parties to Production Schemas

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5851) Add ability to assign parties to Production Schemas

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334738#comment-14334738 ]

Jacques Le Roux commented on OFBIZ-5851:
----------------------------------------

Do you mean that the changes are related to other changes in the issues you reported above?

Or is it rather only because you restructured the RoutingScreens.xml file to have
<!-- Routings -->
and
<!-- Routing Tasks -->
regrouped?

Believe me it's hard to review, try yourself you will understant :/ I know this is committer work, but it should not be so hard for an improvement. You should not mix formatting and restructuring with a new feature when it becomes so complicated, as I said try to compare RoutingScreens.xml once the patch is applied with what's in repo.

I guess  it's related with your previous work on the other issues, but in this case it should be only a matter of adding the new party screens and then later you could restructure. To achieve that, simply
# copy the party screens somewhere.
# Revert your changes
# Add the new party screens in a new section <!--- party screens --> at bottom
# create the patch
# then later make the other no functional changes you want, create a patch and attach it to a new Jira

I can't be more explicit



> Add ability to assign parties to Production Schemas
> ---------------------------------------------------
>
>                 Key: OFBIZ-5851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: manufacturing
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>              Labels: Schema
>         Attachments: OFBIZ-5851-RoutingPartyAssoc.patch
>
>
> Currently it is not possible to assign standard parties to a production schema, e.g. the manufacturing party or the production manager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)