[
https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200988#comment-14200988 ]
Nicolas Malin commented on OFBIZ-5853:
--------------------------------------
{quote}
In general it is not a good practice to change a service in compatible with previous version
{quote}
It's the reason that the entity-auto crud conversion would be never backport on a stable version, but needed to homogenize crud service (for help the maintain).
For the createPartyRole service, in most case, it's call after a PartyRole check and exist an other service ensurePartyRole do the same with a better comprehensive name. So why keep a specific Crud ?
> The createPartyRole service does not check a duplicate key.
> -----------------------------------------------------------
>
> Key: OFBIZ-5853
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5853> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: Trunk
> Reporter: Supatthra Nawicha
> Assignee: Nicolas Malin
> Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-5853.patch, OFBIZ-5853.patch, ofbizbug_CreatePartyroleService.diff
>
>
> The createPartyRole service is changed from minilang to entity-auto which does not check a duplicate key. It effect to the createPartyRelationshipContactAccount service which call the createPartyRole service without check a duplicate key. And it might effect to other code that call the createPartyRole service as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
