[
https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201436#comment-14201436 ]
Hans Bakker commented on OFBIZ-5853:
------------------------------------
I am sorry Party Role is a special case, not the same as other single index entities. Many entities have the role in the key. If you want to add a record in such an entity you have to check if the user has the RoletypeId and when not add it.
THat is why the existence check is in the addRoletype service. As your peer committer I ask you to please put the orginal service back which has existence check.
Do not force me to change the service name only you want to put the autoservice everywhere. This is a special case.
Regards,'Hans
> The createPartyRole service does not check a duplicate key.
> -----------------------------------------------------------
>
> Key: OFBIZ-5853
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5853> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: Trunk
> Reporter: Supatthra Nawicha
> Assignee: Nicolas Malin
> Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-5853.patch, OFBIZ-5853.patch, ofbizbug_CreatePartyroleService.diff
>
>
> The createPartyRole service is changed from minilang to entity-auto which does not check a duplicate key. It effect to the createPartyRelationshipContactAccount service which call the createPartyRole service without check a duplicate key. And it might effect to other code that call the createPartyRole service as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
