[
https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204873#comment-14204873 ]
Jacques Le Roux commented on OFBIZ-5853:
----------------------------------------
Hi Nicolas, Supatthra, Hans,
First Nicolas, I must say that your last patch includes changes already committed at r1637721, so this makes reviews a bit harder ;)
After reverting r1637721 and applying your patch, tests run successfully, testEnsurePartyRole is welcome! Your changes are simple enough to be quickly reviewed and I believe it's the right way to go.
Supatthra, Hans, I understand yourt concerns. This is due to your way of using the trunk instead of a released branch as base for your custom developments. We know it's not a best practices and this strategy is done at our own perils. I include myself, I do the same but I'm more and more considering to start custom projects from a relased branch. It's no only way safer but I found that most of the time, in less than or about 1 year after starting, I have to freeze my local working copy and stop to update from trunk, sometimes at the client's demand or by my own decision. Then I backport only important bug fixes by hand. A bit demanding, but as I said way safer, even with different working areas (test, qa) between your updated local copy and the production area. No needs to say that I tolerate only patches for changes in the OOTB code (this is also demanding).
So with this consideration in mind, I'm for committing Nicolas's proposition (after a patch cleanup). Of course I guess you will not agree, so then please open a discussion in the dev ML in order for us to get to a consensus, thanks.
> The createPartyRole service does not check a duplicate key.
> -----------------------------------------------------------
>
> Key: OFBIZ-5853
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5853> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: Trunk
> Reporter: Supatthra Nawicha
> Assignee: Nicolas Malin
> Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-5853.patch, OFBIZ-5853.patch, ofbizbug_CreatePartyroleService.diff
>
>
> The createPartyRole service is changed from minilang to entity-auto which does not check a duplicate key. It effect to the createPartyRelationshipContactAccount service which call the createPartyRole service without check a duplicate key. And it might effect to other code that call the createPartyRole service as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
