[jira] [Commented] (OFBIZ-5869) correction to changeset r1626462 and r1626463

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252779#comment-14252779 ]

Leon commented on OFBIZ-5869:
-----------------------------

hi, Jacques,

why revert? My new patch was re-generated for those EntityQuery codes.

The EntityQuery.filterByDate(moment) is compatible with EntityUtil.filterByDate(moment). That means:
{quote}
// Maintain existing behavior exhibited by EntityUtil.filterByDate(moment) when moment is null and perform no date filtering
{quote}

> correction to changeset r1626462  and r1626463  
> ------------------------------------------------
>
>                 Key: OFBIZ-5869
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5869
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Release Branch 13.07, Trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>             Fix For: Upcoming Branch, 13.07.02
>
>         Attachments: OFBIZ-5869.patch
>
>
> There's error in this commit. e.g.
> – List<GenericValue> allPCMPs = EntityUtil.filterByDate(delegator.findByAnd("PartyContactMechPurpose", pcmpFindMap, null, false), true);
> ++ allPCWPs = EntityUtil.filterByDate(allPCWPs, null, "contactFromDate", "contactThruDate", true);
> According to EntityUtil.filterByDate(List, EntityCondition, String, String ,Boolean), it filter nothing if condition parameter (the second) is null.
> see OFBIZ-5261.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)