[
https://issues.apache.org/jira/browse/OFBIZ-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262195#comment-14262195 ]
Gareth Carter commented on OFBIZ-5905:
--------------------------------------
Why doesn't createPartyRelationship ensure the PartyRole records exists? Surely that would be easier? roleTypeIdTo and roleTypeIdFrom are part of the PK for PartyRelationship so to me they are a requirement and cannot be null. Or alternatively you could remove the constraint to PartyRole and just have to RoleType entity?
> Change createPartyRelationshipAndRole to use ensurePartyRole
> ------------------------------------------------------------
>
> Key: OFBIZ-5905
> URL:
https://issues.apache.org/jira/browse/OFBIZ-5905> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: Trunk
> Reporter: Gareth Carter
> Assignee: Nicolas Malin
> Priority: Minor
>
> createPartyRelationshipAndRole in party/servicedef/services.xml invokes createPartyRole and then createPartyRelationship. It would be better if createPartyRole was changed to ensurePartyRole so that createPartyRelationshipAndRole can be called without the risk of a duplicate key error in PartyRole
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
