[jira] [Commented] (OFBIZ-5935) Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5935) Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244225#comment-15244225 ]

Rohit Koushal commented on OFBIZ-5935:
--------------------------------------

Explored the recalcTaxTotal service found that it do calculation like :

{code}
diff = SystemGeneratedTax(using calTax) - ExistingTax(Calculate from OrderAjustment of type "SALE_TAX" which includes the recently created "SALE_TAX" adjustment).
if (diff != 0) {
   It will create Adjustment of type "SALE_TAX" with diff amount.
}
{code}

So here we need to understand how we can exclude manually added "SALE_TAX" tax while calculating tax from OrderAdjustment. Because I personally think that diff amount should be the difference of "Old System Generated Tax" and "New System Generated Tax".

> Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5935
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5935
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Christian Carlow
>            Priority: Minor
>         Attachments: Image 094.png
>
>
> For example, if a sales tax adjustment of 0.20 is manually added to a purchase order, another  adjustment will be created for -0.20.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)