[jira] [Commented] (OFBIZ-5953) Problem with new UtilCodec code caused by HTMLEntityCodec.decode()

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-5953) Problem with new UtilCodec code caused by HTMLEntityCodec.decode()

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270760#comment-14270760 ]

Jacopo Cappellato commented on OFBIZ-5953:
------------------------------------------

Thanks for the report Christian and Adrian.
As a temporary workaround we can disable the HTMLEntityCodec wight he following patch:

{code}
Index: framework/base/src/org/ofbiz/base/util/UtilCodec.java
===================================================================
--- framework/base/src/org/ofbiz/base/util/UtilCodec.java (revision 1650452)
+++ framework/base/src/org/ofbiz/base/util/UtilCodec.java (working copy)
@@ -43,7 +43,7 @@
     private static final List<Codec> codecs;
     static {
         List<Codec> tmpCodecs = new ArrayList<Codec>();
-        tmpCodecs.add(new HTMLEntityCodec());
+        //tmpCodecs.add(new HTMLEntityCodec());
         tmpCodecs.add(new PercentCodec());
         codecs = Collections.unmodifiableList(tmpCodecs);
     }
{code}
This will fix the screens.
I am digging into it now.


> Problem with new UtilCodec code caused by HTMLEntityCodec.decode()
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-5953
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5953
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Christian Carlow
>
> From Adrian on ML:
> When I navigate to https://localhost:8443/accounting/control/paymentOverview?paymentId=8004 many exceptions are thrown and the screen fails to render.  I tried changing WidgetWorker.java line 74 to localRequestName = UtilCodec.canonicalize(localRequestName, false, false); which fixed the exceptions, but the generated link is wrong.  I don't know how to fix it.
> Errors related to this class are also thrown at accounting/control/invoiceOverview.  Setting a breakpoint at line 167 of UtilCodec.java shows that 2 HTMLEntityCodec.decode calls transforms the URL from
> EditAcctgTrans?acctgTransId=10070&amp;organizationPartyId=10010 to
> EditAcctgTrans?acctgTransId=10070&organizationPartyId=10010 to
> EditAcctgTrans?acctgTransId=10070∨ganizationPartyId=10010.
> Not sure if the error is in class UtilCode or HTMLEntityCodec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)