[
https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465459 ]
Chris Howe commented on OFBIZ-605:
----------------------------------
Despite the criticism about this from the ML, I think it is ready for JIRA. I may not agree with the idea of combining style sheets in general, but after reviewing tabstyles.css , it really hasn't been maintained in such a way to benefit from the separation and if that's the direction of the consensus, then "step in the right direction" is my preference rather than no action. I have not yet dropped this css into my deployment, but it should be a rather simple review. Since the backend stuff really hasn't seen too much risque css applications, this should at worst be a fairly harmless improvement and at best a great consolidation.
I will sometime this week drop it into a deployment and check it out more thoroughly and report back.
Aside from the em to px issue, if something is to be 0px or 0em, there should be no units. It should just be 0 (ie margin: 0; not margin: 0px;)
Both no units and px -> em modifications have been included
> Consolidate backend css files
> -----------------------------
>
> Key: OFBIZ-605
> URL:
https://issues.apache.org/jira/browse/OFBIZ-605> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: framework_v2.patch, maincss.css
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
