[jira] Commented: (OFBIZ-605) Consolidate backend css files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-605) Consolidate backend css files

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465503 ]

Chris Howe commented on OFBIZ-605:
----------------------------------

As far as separation, I think there's a decent case to be made to separate the files where the
/* ================== */

stuff is.  But again, step in the right direction is the approach that should be taken here.  The tabstyles.css wasn't maintained in such a way to really benefit from the separation of the files (rather, the templates did not take advantage of the separation as such)

The part preventing a CSS Zen Garden approach isn't the number of sylesheets being used, but instead the use of non semantic markup that's pervasive throughout the project (which Jacopo has tackled recently with the changing head1 to h1 and removing tabletext classes).  There still exists much to do as far as removing "left", "right", "center", etc class names.

If it upset you that I posted your improvements and my modifications to the JIRA with the ASF flag, I certainly apologize.  However, I will not post it to the mailing as licensing is ambiguous and as I understand it, technically has the same legal obstacles  as the sandbox or unofficial hack-a-thons.  Your OFBiz derivative work posted to the ML with the Apache header allows for anyone to make modifications, redistribute, etc and there was rather clear communication that yours was one-off work.  However, if I make a modification and repost it to the ML that is now a two-off work and it is unclear the licensing intent of the collaborative work.  Posting files to JIRA with the ASF flag does not mean the file is meant to go into the project as is, that is for the committers to decide.  However, posting the file to JIRA rejecting the ASF flag means that you are not granting the ASF license it needs to include it were it to be in condition that pleased the committers.  If you don't object to me posting it to JIRA, I will repost it here.

> Consolidate backend css files
> -----------------------------
>
>                 Key: OFBIZ-605
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-605
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_v2.patch
>
>
> Consolidate maincss.css and tabstyles.css files into one file - maincss.css.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira