[jira] Commented: (OFBIZ-617) zh properties in progress

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468011 ]

Jacques Le Roux commented on OFBIZ-617:
---------------------------------------

Shi,

I there are 3 problems in your patch. The 2d is blocking

1. *Please* use relatice pathes in your patches, I'm really tired to repeat that over and over :(. Good to read : http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

2. You used the old ASL2 header in your files
    #####################################################################
    # Copyright 2001-2006 The Apache Software Foundation
    #
    # Licensed under the Apache License, Version 2.0 (the "License"); you may not
    # use this file except in compliance with the License. You may obtain a copy of
    # the License at
    #
    # http://www.apache.org/licenses/LICENSE-2.0
    #
    # Unless required by applicable law or agreed to in writing, software
    # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    # License for the specific language governing permissions and limitations
    # under the License.
    #####################################################################
please replace with the new one
    ###############################################################################
    # Licensed to the Apache Software Foundation (ASF) under one
    # or more contributor license agreements.  See the NOTICE file
    # distributed with this work for additional information
    # regarding copyright ownership.  The ASF licenses this file
    # to you under the Apache License, Version 2.0 (the
    # "License"); you may not use this file except in compliance
    # with the License.  You may obtain a copy of the License at
    #
    # http://www.apache.org/licenses/LICENSE-2.0
    #
    # Unless required by applicable law or agreed to in writing,
    # software distributed under the License is distributed on an
    # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    # KIND, either express or implied.  See the License for the
    # specific language governing permissions and limitations
    # under the License.
    ###############################################################################
this is a legal issue. I tried to replace by myself but this makes too much troubles and I don't want to disturb others work (I would end up with not concerned files modified)

3. I also noticed slight changes in some labels of
    PartyUiLabels_zh.properties
    ProductUiLabels_zh.properties
    ManufacturingUiLabels_zh.properties
But as it's an huge work I shall prefer to commit it all and let chinese community deal with problems if any. It's the moment, now...

> zh properties in progress
> -------------------------
>
>                 Key: OFBIZ-617
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-617
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Wish
>            Reporter: Shi Yusen
>            Priority: Trivial
>         Attachments: OFBiz-zh-20070126-shiys.patch
>
>
> My translation is still in progress. I put my patch here:http://www.langhua.cn/download/ofbiz-properties-zh-20070112.patch
> Thanks to the authors of Italian and French properties! Sometimes I can get the real meanings from your works.
> BTW, what's the "Must RSVP" mean?
> Regards,
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.