[jira] [Commented] (OFBIZ-6207) Anyone can view any Request or Quote

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379199#comment-14379199 ]

Forrest Rae commented on OFBIZ-6207:
------------------------------------

So, in 13.07, <entity-one> in the widget will call GenericDelegator.findOne().  This checks that you're only using primary keys for the search.  My patch seems to cause a problem as it was using partyId as part of the search criteria.  partyId is not a PK of Quote.

What is the recommended way of checking the Quote.partyId field to make sure it matches userLogin.partyId in the actions section of the specialpurpose/ecommerce/widget/QuoteScreens.xml#ViewQuote screen?

None of this matters in Trunk as the <entity-one> in the screen never results in a call to GenericDelegator.findOne().

> Anyone can view any Request or Quote
> ------------------------------------
>
>                 Key: OFBIZ-6207
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6207
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Trunk, 13.07.01
>            Reporter: Forrest Rae
>            Priority: Critical
>              Labels: security
>         Attachments: OFBIZ-6207-second-attempt.patch, OFBIZ-6207.patch
>
>
> This is a security bug in the ecommerce application.  Anyone can view any quote or request in the system regardless of the associated partyId.  They can do this via URL parameter manipulation.
> Reproduction:
> 1) Login to the ecommerce application as DemoCustomer.
> 2) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9000 to view your own request.
> 3) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9001 to view DemoCustAgent's request.
> 4) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9002 to view DemoCustomer2's request.
> Same goes for Quotes, although there are no quotes in the Demo data.  The attach patch fixes this issue.
> Would like this issue back ported to release 13.07 please.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)