[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385231#comment-14385231 ]
Taher Alkhateeb commented on OFBIZ-6217:
----------------------------------------
Hi Adrian,
Good catch. The reason I did not apply the generics is because I thought I would break the function signature of the callee object. Your solution looks good. However, if you look at OfbizBshBsfEngine.java for example, you will see that I will actually break the signature so I cannot do anything about it.
Do you want me to repatch or can you correct it from your side?
> fix warnings in trunk on java source code
> -----------------------------------------
>
> Key: OFBIZ-6217
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6217> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Taher Alkhateeb
> Assignee: Adrian Crum
> Priority: Minor
> Labels: java, warning
> Fix For: Upcoming Branch
>
> Attachments: remove_unused_imports.patch, warnings_patch_2.patch
>
>
> Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly.
> I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
