[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489053#comment-14489053 ]

Jacques Le Roux commented on OFBIZ-6217:
----------------------------------------

Hi Taher,

# What is the strategy on applying patches?
# What is the normal expected number of days for a commit to enter the system?
# How should we setup our expectations and / or reminders accordingly?

# There are no established rules. Personaly I 1st apply patches on bug fixes by order of importance, then improvements and then new features. New features are last because they often need longer reviews.
# It really depends, some patches are only applied years after, still they are. This said I sometimes update patches to avoid losing them for ever...
# Again no rules, when I feel something is important (eg really warnings are not that important even if I agree annoying) I don't hesitate to remind someone after a week and then a month, etc. But you can't expect committers (remember: volunteers on free time) to jump when you ask them ;)

> fix warnings in trunk on java source code
> -----------------------------------------
>
>                 Key: OFBIZ-6217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Taher Alkhateeb
>            Assignee: Adrian Crum
>            Priority: Minor
>              Labels: java, warning
>             Fix For: Upcoming Branch
>
>         Attachments: remove_unused_imports.patch, warnings_patch_2.patch, warnings_patch_2.patch
>
>
> Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly.
> I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)