[jira] [Commented] (OFBIZ-6219) NPE while rendering content uisng screen widget

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383716#comment-14383716 ]

Deepak Dixit commented on OFBIZ-6219:
-------------------------------------

I think its different:
Your Patch
{code}
-                    if (content != null) {
+                    if (content != null && content.get("dataResourceId") != null) {
                         expandedDataResourceId = content.getString("dataResourceId");
                     } else {
                         String errMsg = "Could not find content with contentId [" + expandedContentId + "] ";
{code}

Mine Patch
{code}
                     }
                     if (content != null) {
-                        expandedDataResourceId = content.getString("dataResourceId");
+                        if (content.get("dataResourceId") != null) expandedDataResourceId = content.getString("dataResourceId");
                     } else {
                         String errMsg = "Could not find content with contentId [" + expandedContentId + "] ";
                         Debug.logError(errMsg, module);
{code}

> NPE while rendering content uisng screen widget
> -----------------------------------------------
>
>                 Key: OFBIZ-6219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6219
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content, framework
>    Affects Versions: Release Branch 14.12, Trunk
>            Reporter: Deepak Dixit
>         Attachments: OFBIZ-6219.patch, OFBIZ-6219.patch, OFBIZ-6219.patch
>
>
> If we want to render an content that does't have dataResourceId then screen widget throwing NPE
> {code}
> Caused by: java.lang.NullPointerException
> at org.ofbiz.widget.model.ModelScreenWidget$Content.renderWidgetString(ModelScreenWidget.java:1399) ~[ofbiz-widget.jar:?]
> at org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) ~[ofbiz-widget.jar:?]
> at org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) ~[ofbiz-widget.jar:?]
> at org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) ~[ofbiz-widget.jar:?]
> at org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:136) ~[ofbiz-widget.jar:?]
> at org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:98) ~[ofbiz-widget.jar:?]
> {code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)