[jira] [Commented] (OFBIZ-6270) base/json/JSON has been removed, with no deprecation window

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-6270) base/json/JSON has been removed, with no deprecation window

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507330#comment-14507330 ]

Adam Heath commented on OFBIZ-6270:
-----------------------------------

Because I plan on also adding test cases(which were also removed); they will probably even be based on the removed test case classes.  And, since I haven't yet done the work, and I am following the release-first/release-often workflow, I created a branch early, and committed code early, in case anyone else wants to work with me.

> base/json/JSON has been removed, with no deprecation window
> -----------------------------------------------------------
>
>                 Key: OFBIZ-6270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk, 12.04.04
>            Reporter: Adam Heath
>            Assignee: Adam Heath
>            Priority: Critical
>
> The antlr-based json parser(at org.ofbiz.base.json.JSON.cc) was removed last October(2014-10-27).  However, no backwards-compatible class was left in place, with a proper @Deprecation tag applied.
> The proper approach should have been to leave the class in place, adding @Deprecation, and leaving the json-lib.jar in place.  Then, after one successful release, removing the actual code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)