[jira] [Commented] (OFBIZ-6286) SagePay classes make use of deprecated httpclient features

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507282#comment-14507282 ]

Adam Heath commented on OFBIZ-6286:
-----------------------------------

  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:41: warning: [deprecation] DefaultHtt
pClient in org.apache.http.impl.client has been deprecated
  [javac17] import org.apache.http.impl.client.DefaultHttpClient;
  [javac17]                                   ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:43: warning: [deprecation] BasicHttpP
arams in org.apache.http.params has been deprecated
  [javac17] import org.apache.http.params.BasicHttpParams;
  [javac17]                              ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:44: warning: [deprecation] HttpParams
 in org.apache.http.params has been deprecated
  [javac17] import org.apache.http.params.HttpParams;
  [javac17]                              ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:41: warning: [deprecation] DefaultHttpClient in org.apache.http.impl.client has been deprecated
  [javac17] import org.apache.http.impl.client.DefaultHttpClient;
  [javac17]                                   ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:43: warning: [deprecation] BasicHttpParams in org.apache.http.params has been deprecated
  [javac17] import org.apache.http.params.BasicHttpParams;
  [javac17]                              ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:44: warning: [deprecation] HttpParams in org.apache.http.params has been deprecated
  [javac17] import org.apache.http.params.HttpParams;
  [javac17]                              ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:41: warning: [deprecation] DefaultHttpClient in org.apache.http.impl.client has been deprecated
  [javac17] import org.apache.http.impl.client.DefaultHttpClient;
  [javac17]                                   ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:43: warning: [deprecation] BasicHttpParams in org.apache.http.params has been deprecated
  [javac17] import org.apache.http.params.BasicHttpParams;
  [javac17]                              ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:44: warning: [deprecation] HttpParams in org.apache.http.params has been deprecated
  [javac17] import org.apache.http.params.HttpParams;
  [javac17]                              ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayServices.java:282: warning: [deprecation] getConnectionManager() in HttpClient has been deprecated
  [javac17]             httpClient.getConnectionManager().shutdown();
  [javac17]                       ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayServices.java:378: warning: [deprecation] getConnectionManager() in HttpClient has been deprecated
  [javac17]             httpClient.getConnectionManager().shutdown();
  [javac17]                       ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayServices.java:472: warning: [deprecation] getConnectionManager() in HttpClient has been deprecated
  [javac17]             httpClient.getConnectionManager().shutdown();
  [javac17]                       ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayServices.java:564: warning: [deprecation] getConnectionManager() in HttpClient has been deprecated
  [javac17]             httpClient.getConnectionManager().shutdown();
  [javac17]                       ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayServices.java:675: warning: [deprecation] getConnectionManager() in HttpClient has been deprecated
  [javac17]             httpClient.getConnectionManager().shutdown();
  [javac17]                       ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:164: warning: [deprecation] HttpParams in org.apache.http.params has been deprecated
  [javac17]         HttpParams params = new BasicHttpParams();
  [javac17]         ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:164: warning: [deprecation] BasicHttpParams in org.apache.http.params has been deprecated
  [javac17]         HttpParams params = new BasicHttpParams();
  [javac17]                                 ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:165: warning: [deprecation] setParams(HttpParams) in AbstractHttpMessage has been deprecated
  [javac17]         httpPost.setParams(params);
  [javac17]                 ^
  [javac17] /srv/ofbiz/apache-git/applications/accounting/src/org/ofbiz/accounting/thirdparty/sagepay/SagePayUtil.java:182: warning: [deprecation] DefaultHttpClient in org.apache.http.impl.client has been deprecated
  [javac17]         HttpClient  httpClient = new DefaultHttpClient();
  [javac17]                                      ^

> SagePay classes make use of deprecated httpclient features
> ----------------------------------------------------------
>
>                 Key: OFBIZ-6286
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6286
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Adam Heath
>            Priority: Minor
>
> I have not checked httpclient upstream to see what should be used in place of the deprecated classes/methods.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)