[jira] [Commented] (OFBIZ-6408) Adding a group order generates an error

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065281#comment-15065281 ]

Rahul Bhooteshwar commented on OFBIZ-6408:
------------------------------------------

While creating Group Order, 'required' validation is only on the client side for fromDate & thruDate (i.e. Deal Start Date & Deal End Date).

For showing Edit Link in ListProductGroupOrder form use-when attribute compares thruDate with nowTimeStamp. In the case of empty thruDate,  the use-when attribute will get  "true&&" and this will generate the above-mentioned error.

The same error can occur in the case of empty reqOrderQty or soldOrderQty. So there should be a check at this place for empty/null values before using those with "use-when" operator. Removing thruDate comparison can also be a quick fix for the same.

Besides this issue, including fromDate in Primary Key of ProductGroupOrder can be a good improvement.

> Adding a group order generates an error
> ---------------------------------------
>
>                 Key: OFBIZ-6408
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6408
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Trunk, 13.07.01
>            Reporter: Pierre Smits
>              Labels: GroupOrder, catalog
>
> When adding a Group Order for a product the following error is returned:
> {code}
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://product/widget/catalog/ProductScreens.xml#ViewProductGroupOrder]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://product/widget/catalog/ProductScreens.xml#CommonProductDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://product/widget/catalog/CommonScreens.xml#main-decorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ) (Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. )) (Error rendering screen [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ) (Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ))) (Error rendering screen [component://product/widget/catalog/CommonScreens.xml#main-decorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ) (Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. )) (Error rendering screen [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ) (Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. )))) (Error rendering screen [component://product/widget/catalog/ProductScreens.xml#CommonProductDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://product/widget/catalog/CommonScreens.xml#main-decorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ) (Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. )) (Error rendering screen [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ) (Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ))) (Error rendering screen [component://product/widget/catalog/CommonScreens.xml#main-decorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ) (Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. )) (Error rendering screen [component://commonext/widget/CommonScreens.xml#ApplicationDecorator]: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. ) (Error rendering screen [component://common/widget/CommonScreens.xml#GlobalDecorator]: java.lang.RuntimeException: Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. (Error rendering included form named [ListProductGroupOrder] at location [component://product/widget/catalog/ProductForms.xml]: java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. java.lang.IllegalArgumentException: Error evaluating BeanShell use-when condition [true&&] on the field editLink of form ListProductGroupOrder: In file: inline evaluation of: ``true&&;'' Encountered ";" at line 1, column 7. )))))
> {code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)