[jira] [Commented] (OFBIZ-6587) buildSurveyFromPdf generates an NPE

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103120#comment-15103120 ]

Suraj Khurana commented on OFBIZ-6587:
--------------------------------------

Initial fix for this is available in the patch in which we have restricted user at client as well as server side.
User should not be able to submit the form without contentId (PDF Content Id).
Please have a look, adding patch for the same.

> buildSurveyFromPdf generates an NPE
> -----------------------------------
>
>                 Key: OFBIZ-6587
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6587
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content
>            Reporter: Pierre Smits
>              Labels: survey
>         Attachments: OFBIZ-6587.patch
>
>
> {code}
> [java] 2015-08-28 18:25:42,712 |ttp-bio-8443-exec-43 |ControlServlet                |T| [[[buildSurveyFromPdf(Domain:https://localhost)] Request Done- total:0.214,since last([buildSurveyFromP...):0.214]]
>      [java] 2015-08-28 18:25:47,756 |ttp-bio-8443-exec-43 |ControlServlet                |T| [[[buildSurveyFromPdf(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
>      [java] 2015-08-28 18:25:47,761 |ttp-bio-8443-exec-43 |PdfSurveyServices             |E| Error generating PDF: java.lang.NullPointerException
>      [java] java.lang.NullPointerException
>      [java] at org.ofbiz.content.survey.PdfSurveyServices.buildSurveyFromPdf(PdfSurveyServices.java:90) [ofbiz-content.jar:?]
>      [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_45]
>      [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_45]
>      [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45]
>      [java] at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45]
>      [java] at org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100) [ofbiz-service.jar:?]
>      [java] at org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57) [ofbiz-service.jar:?]
>      [java] at org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:395) [ofbiz-service.jar:?]
>      [java] at org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227) [ofbiz-service.jar:?]
>      [java] at org.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88) [ofbiz-service.jar:?]
>      [java] at org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:340) [ofbiz-webapp.jar:?]
>      [java] at org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:759) [ofbiz-webapp.jar:?]
>      [java] at org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:476) [ofbiz-webapp.jar:?]
>      [java] at org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) [ofbiz-webapp.jar:?]
>      [java] at org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:88) [ofbiz-webapp.jar:?]
>      [java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:646) [servlet-api-3.0.jar:?]
>      [java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) [servlet-api-3.0.jar:?]
>      [java] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:324) [ofbiz-webapp.jar:?]
>      [java] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:421) [tomcat-7.0.59-catalina.jar:7.0.59]
>      [java] at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1074) [tomcat-7.0.59-tomcat-coyote.jar:7.0.59]
>      [java] at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:611) [tomcat-7.0.59-tomcat-coyote.jar:7.0.59]
>      [java] at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316) [tomcat-7.0.59-tomcat-coyote.jar:7.0.59]
>      [java] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_45]
>      [java] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_45]
>      [java] at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-7.0.59-tomcat-coyote.jar:7.0.59]
>      [java] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45]
> {code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)