[jira] [Commented] (OFBIZ-6697) CommunicationServices.createAttachmentContent duplicates attachments for existing CommunicationEvents

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-6697) CommunicationServices.createAttachmentContent duplicates attachments for existing CommunicationEvents

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076753#comment-15076753 ]

Scott Gray commented on OFBIZ-6697:
-----------------------------------

There's no need to change the method signature since you're getting the delegator from the dispatcher anyway.  And if the signature did need to change, the old should be deprecated rather than removed.

Otherwise the patch looks fine to me, I haven't tested it though.

> CommunicationServices.createAttachmentContent duplicates attachments for existing CommunicationEvents
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-6697
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6697
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Gareth Carter
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: FixDuplicateCommEventAttachments.patch
>
>
> When sending an email from a CommunicationEvent that exists in the database prior to calling sendMail/sendMailMultiPart, the seca updateCommEventAfterEmail will call createAttachmentContent and store any attachments into ImageDataResource and be referenced by the CommunicationEvent even if the attachments already exist in the database (and stored somewhere else).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)