[jira] [Commented] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010675#comment-15010675 ]

Gil Portenseigne commented on OFBIZ-6703:
-----------------------------------------

Hi all, Sorry for waking up a bit late on this subject, but the best way to fix this bug was replacing createPartyRole service call by ensurePartyRole service, which is done for this use.

Indeed the entity-auto improvments made by Nicolas did not check every createPartyRole usage, leading to this kind of bug.

Reverting entity-auto implementation is a bad solution, bringing back createPartyRole/ensurePartyRole service usage duplication, and createPartyRole naming as a CRUD service to a different one...

Hans, Internal check is already done by ensurePartyRole, it was just the information missing here !

> Cannot create more than one lead in the SFA component by same user
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-6703
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6703
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: Trunk
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>             Fix For: 14.12.01, Upcoming Branch
>
>
> Repeat steps:
> # go to SFA component and click on leads
> # click on create new
> # fill mandatory information and save
> # repeat the above steps again and observe failure
> The reason for the failure is that the implementation of the createLead service tries to create a PartyRole of type OWNER every time a lead is created. So it works only the first time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)