[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235036#comment-15235036 ]

Jacques Le Roux commented on OFBIZ-6705:
----------------------------------------

From [our last discussion|http://markmail.org/message/qubd7w3eat3p7dfj] and OFBIZ-6458 it was OK to add Java 8 new features, apart [~chrisg] [then|http://markmail.org/message/yxiwi7dh6xzuzmao], I'd like to have his opinion now. I believe everybody else agreed that since it's not yet released R14.12.01 could have Java 8 new features.

We have also ASF Builbot and all demos running with Java 8 only now.

> some files set viewIndex to 1 by default rather than 0
> ------------------------------------------------------
>
>                 Key: OFBIZ-6705
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6705
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Gareth Carter
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:        if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:        <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex = request.getParameter("viewIndex") ? Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:    viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:            viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)